Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert PRs #1097, #1152. #1182

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore: Revert PRs #1097, #1152. #1182

merged 1 commit into from
Mar 14, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Mar 14, 2024

Description of the Changes

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1182/documentation/ .

@stoobie
Copy link
Collaborator Author

stoobie commented Mar 14, 2024

@alon-dotan-starkware Please review.

@stoobie stoobie merged commit bcc5f56 into main Mar 14, 2024
5 of 6 checks passed
@stoobie stoobie deleted the steve/revert_prs_1097_1152 branch March 14, 2024 15:06
@stoobie
Copy link
Collaborator Author

stoobie commented Apr 1, 2024

For now, at least it's possible to generate a preview locally by running yarn (required 1st time only per worktree) and then ./build_local_site.sh from the repo's root directory.

@xiaolou86
Copy link
Contributor

xiaolou86 commented Apr 1, 2024

@stoobie thank you for your explanation. I am very sorry. Obviously I'm not an expert, I even a newbie to github's workflow. I just began to learn it when I met you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants